feat(input-otp): convert to a form associated shadow component #30785#30884
feat(input-otp): convert to a form associated shadow component #30785#30884brandyscarney wants to merge 14 commits intoFW-6912-textareafrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
package: core
github-actions
bot
added
package: vue
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
LGTM, one comment but not a blocker
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looking good! I left a couple of comments, but I consider them non-blockers. Well done!
| * Called when the form is reset. | ||
| * Resets the component's value. | ||
| */ | ||
| formResetCallback() { |
There was a problem hiding this comment.
Nice! Should we also add support for formStateRestoreCallback for when the browser populates the form?
| /** | ||
| * Updates the form value and reports validity state to the browser via | ||
| * ElementInternals. This should be called when the component loads, when | ||
| * the required prop changes, when the disabled prop changes, and when the value |
There was a problem hiding this comment.
As far as I can tell there is no required prop? I'm assuming this was an accident, but I could also be missing something!
There was a problem hiding this comment.
You're right! I started adding the required prop to match textarea, but I removed it when it got too complicated and I realized we should do a design doc first to determine how it should work.
3 participants
Issue number: internal
What is the current behavior?
Input Otp uses
scopedencapsulation. This causes issues with CSP compatibility and is inconsistent with our goal of having all components use Shadow DOM.What is the new behavior?
ion-input-otptoshadowwithformAssociated: trueDoes this introduce a breaking change?
Other information