fix(searchbar): clear timeouts#30849
Closed
KillerCodeMonkey wants to merge 1 commit intoionic-team:mainfrom
Closed
fix(searchbar): clear timeouts#30849KillerCodeMonkey wants to merge 1 commit intoionic-team:mainfrom
KillerCodeMonkey wants to merge 1 commit intoionic-team:mainfrom
Conversation
|
@KillerCodeMonkey is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
2 tasks
KillerCodeMonkey
changed the title
Contributor
Author
|
closed in favor of #30851 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #
What is the current behavior?
We have flaky tests in an ionic angular project that root cause are not cleaned up timeouts.
I commented out the timeout in the searchbar componentWillLoad method. and after several runs no flaky tests at all.
My guess -> test runs faster than the 300ms it takes til the timeout runs. Everything is cleaned up, but not the ionic timeouts (i think i saw something similar in the "label" component)
What is the new behavior?
Timeouts are cleaned on disconnect.
Does this introduce a breaking change?
Other information
Testrunner is vitest + angular 20 and latest ionic version 8.x