fix(datetime): remove ion-buttons to fix CSP violations#30770
Merged
brandyscarney merged 31 commits intonextfrom Feb 5, 2026
Merged
fix(datetime): remove ion-buttons to fix CSP violations#30770brandyscarney merged 31 commits intonextfrom
brandyscarney merged 31 commits intonextfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
df13f40 to
340c060
Compare
brandyscarney
commented
Dec 17, 2025
Member
Author
There was a problem hiding this comment.
I renamed the existing test for custom buttons (one button passed) and then added 2 more tests showing how it looks when you pass 2 or 3 buttons to make sure the behavior was the same as before.
brandyscarney
commented
Dec 18, 2025
Member
Author
There was a problem hiding this comment.
I compared this test locally with what's on next and saw no differences so I think this might just be Playwright: https://ionic-framework-git-next-ionic1.vercel.app/src/components/datetime/test/custom
thetaPC
requested changes
Jan 16, 2026
...ime.e2e.ts-snapshots/datetime-footer-clear-button-ionic-md-ltr-light-Mobile-Chrome-linux.png
Show resolved
Hide resolved
ShaneK
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The Datetime component breaks CSP rules due to the following:
ion-buttonswhich usesscopedencapsulation.ionictheme, it imports Phosphor icons as data URIs, which are blocked byconnect-src 'self' blob:.What is the new behavior?
ion-buttons, removing the dependency on a scoped componention-buttonsion-buttonto change its styles based on being inside of anion-datetimePhosphor icons have not been removed because there is a workaround for it and we will remove its usage across all components in future work.
Does this introduce a breaking change?
This shouldn't cause breaking changes but because we are no longer recommending users use
ion-buttonswith custom buttons I am marking it as a breaking change.