feat(card): convert card-content to shadow DOM#30759
Open
brandyscarney wants to merge 14 commits intonextfrom
Open
feat(card): convert card-content to shadow DOM#30759brandyscarney wants to merge 14 commits intonextfrom
brandyscarney wants to merge 14 commits intonextfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
TODO font size does not work due to global styles
brandyscarney
commented
Dec 18, 2025
...mponents/card/test/basic/card.e2e.ts-snapshots/card-headings-ios-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
thetaPC
approved these changes
Jan 16, 2026
Contributor
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
LGTM, I do lean towards removing the snapshots but that's not a blocker.
ShaneK
approved these changes
Jan 27, 2026
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
This looks good to me! Only one very minor non-blocking question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Card content has no encapsulation.
What is the new behavior?
Convert
ion-card-contentto Shadow DOM which improves consistency among components & CSP compatibility.Does this introduce a breaking change?
There should not be any breaking changes related to targeting inner elements since
ion-card-contentdoes not have any internal elements of its own. However, some user styles may break due to the removal of thecard-content-{mode}class or changes in selector specificity. Additionally, the styles targeting heading elements in card-content were removed. Users that wish to have custom styling for headings should add their own CSS targeting them.