feat(select): pass cancelText property to modal interface#30282
feat(select): pass cancelText property to modal interface#30282thetaPC merged 15 commits intoionic-team:feature-8.8from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
package: core
niconaso
changed the title
|
Thank you for submitting the PR! Please create an issue for this. We'd like to understand the use case for this feature before we expose this API. Thanks! |
ionitron-bot
bot
added
triage
and removed
needs: reply
| component: 'ion-select-modal', | ||
| componentProps: { | ||
| header: interfaceOptions.header, | ||
| closeText: interfaceOptions.closeText, |
There was a problem hiding this comment.
cancelText: this.cancelText,
I consider better to use the existing property cancelText, instead of creating a new one, so we avoid having two properties for the same thing.
There was a problem hiding this comment.
I agree with you @luisbytes. Thanks for letting me know.
I'll change it and push the changes today.
|
Is there any date when this feature might get released? |
|
We appreciate your interest in this feature! While the team does plan to address it at some point, there's no set timeframe for its release. We recommend subscribing to the issue for any future updates. |
Add a new property to customize the close button in the select when the interface is Modal.
thetaPC
force-pushed
the
feature/add-close-text
branch
from
14c7d9c to
5225f7b
Compare
|
@thetaPC is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
thetaPC
changed the title
There was a problem hiding this comment.
The difference is the cancel button text. Since we are passing the cancel button text from select, it now uses the default value that select sets for cancel button. I believe this is actually a fix because it lines up with the other interfaces.
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
This looks great! Thank you for the PR! 🚀
brandyscarney
changed the title
|
Thank you for the PR! The feature will be released in v8.8!! |
6 participants
Issue number: resolves #30295
What is the current behavior?
The cancel button within
ion-select-modalcannot be changed.What is the new behavior?
cancelText, toion-select-modalto customize the cancel button text.ion-selectto pass thecancelTextvalue toion-select-modal.Does this introduce a breaking change?
Preview