Merge pull request #2464 from LittleGreenYoda42/test/fix-slack-long-line-handling

hipstersmoothie · web-flow · commit 0509a792314d · 2024-06-28T12:52:16.000-04:00
fix: handling of long strings in slack plugin
diff --git a/plugins/slack/src/index.ts b/plugins/slack/src/index.ts
@@ -91,16 +91,17 @@ interface Block {
 const CHANGELOG_LINE = /^\s*•/;
 type Messages = [Block[], ...Array<Block[] | FileUpload>];
 
-/** Split a long spring into chunks by character limit */
+/** Split a long string into chunks by character limit */
 const splitCharacterLimitAtNewline = (line: string, charLimit: number) => {
   const splitLines = [];
   let buffer = line;
 
   while (buffer) {
     // get the \n closest to the char limit
-    const newlineIndex = buffer.lastIndexOf("\n", charLimit) || charLimit;
-    splitLines.push(buffer.slice(0, newlineIndex));
-    buffer = buffer.slice(newlineIndex);
+    const newlineIndex = buffer.indexOf("\n", charLimit);
+    const endOfLine = newlineIndex >= 0 ? newlineIndex : charLimit;
+    splitLines.push(buffer.slice(0, endOfLine));
+    buffer = buffer.slice(endOfLine);
   }
 
   return splitLines;
