Bugfix: use apparent_encoding if encoding is set to None#91
Closed
maiiku wants to merge 2 commits intointercom:masterfrom
Closed
Bugfix: use apparent_encoding if encoding is set to None#91maiiku wants to merge 2 commits intointercom:masterfrom
maiiku wants to merge 2 commits intointercom:masterfrom
Conversation
1 similar comment
maiiku
force-pushed
the
bugfix_use_apparent_encoding_when_none_provided
branch
from
1b0f1d6 to
964444b
Compare
Author
Contributor
|
Thanks @maiiku, I'll take a look at this today. |
jkeyes
added a commit
that referenced
this pull request
May 12, 2015
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defeat value for encoding attribute in class
requests.ResponseisNone. If server doesn't set it to something useful (ie on 202 responses) it remainsNoneand gets passed todecode()and thus fails. Classrequests. Responsehas very nice fallback, apparent_encoding, that is provided by the chardet library and can come in handy here.