Skip to content

Removing unused count api operation. #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkeyes merged 2 commits into from
Feb 9, 2017
Merged

Removing unused count api operation. #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0fabf8
Removing unused `count` api operation.
jkeyes Feb 9, 2017
b85ce26
Updating version number to 3.0.3
jkeyes Feb 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
Changelog
=========

* 3.0.3
* Removed `count` API operation, this is supported via `client.counts` now. (`#152 <https://github.com/jkeyes/python-intercom/pull/152>`_)
* 3.0.2
* Added multipage support for Event.find_all. (`#147 <https://github.com/jkeyes/python-intercom/pull/147>`_)
* 3.0.1
Expand Down
2 changes: 1 addition & 1 deletion intercom/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
MultipleMatchingUsersError, RateLimitExceeded, ResourceNotFound,
ServerError, ServiceUnavailableError, UnexpectedError, TokenUnauthorizedError)

__version__ = '3.0.2'
__version__ = '3.0.3'


RELATED_DOCS_TEXT = "See https://github.com/jkeyes/python-intercom \
Expand Down
15 changes: 0 additions & 15 deletions intercom/api_operations/count.py
View file
Open in desktop

This file was deleted.

16 changes: 2 additions & 14 deletions intercom/count.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,8 @@
# -*- coding: utf-8 -*-
"""Count Resource."""

from intercom.traits.api_resource import Resource


class Count(Resource):
pass

# @classmethod
# def fetch_for_app(cls):
# return Count.find()

# @classmethod
# def do_broken_down_count(cls, entity_to_count, count_context):
# result = cls.fetch_broken_down_count(entity_to_count, count_context)
# return getattr(result, entity_to_count)[count_context]

# @classmethod
# def fetch_broken_down_count(cls, entity_to_count, count_context):
# return Count.find(type=entity_to_count, count=count_context)
"""Collection class for Counts."""
9 changes: 0 additions & 9 deletions intercom/service/count.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,3 @@ def for_app(self):

def for_type(self, type, count=None):
return self.find(type=type, count=count)

# @classmethod
# def do_broken_down_count(cls, entity_to_count, count_context):
# result = cls.fetch_broken_down_count(entity_to_count, count_context)
# return getattr(result, entity_to_count)[count_context]

# @classmethod
# def fetch_broken_down_count(cls, entity_to_count, count_context):
# return Count.find(type=entity_to_count, count=count_context)