Skip to content

Adding missing find_all capability to event resources #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkeyes merged 1 commit into from
Feb 6, 2017
Merged

Adding missing find_all capability to event resources #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion intercom/api_operations/find_all.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
class FindAll(object):
"""A mixin that provides `find_all` functionality."""

proxy_class = CollectionProxy

def find_all(self, **params):
"""Find all instances of the resource based on the supplied parameters."""
collection = utils.resource_class_to_collection_name(
Expand All @@ -17,6 +19,6 @@ def find_all(self, **params):
else:
finder_url = "/%s" % (collection)
finder_params = params
return CollectionProxy(
return self.proxy_class(
self.client, self.collection_class, collection,
finder_url, finder_params)
12 changes: 11 additions & 1 deletion intercom/service/event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,20 @@
from intercom import event
from intercom.api_operations.bulk import Submit
from intercom.api_operations.save import Save
from intercom.api_operations.find_all import FindAll
from intercom.service.base_service import BaseService
from intercom.collection_proxy import CollectionProxy


class Event(BaseService, Save, Submit):
class EventCollectionProxy(CollectionProxy):

def paging_info_present(self, response):
return 'pages' in response and 'next' in response['pages']


class Event(BaseService, Save, Submit, FindAll):

proxy_class = EventCollectionProxy

@property
def collection_class(self):
Expand Down