Adding missing find_all capability to event resources#141
Merged
jkeyes merged 1 commit intointercom:events-find-allfrom Feb 6, 2017
Merged
Adding missing find_all capability to event resources#141jkeyes merged 1 commit intointercom:events-find-allfrom
find_all capability to event resources#141jkeyes merged 1 commit intointercom:events-find-allfrom
Conversation
- Added the ability to override the default CollectionProxy class in the FindAll mixin - Created a dedicated Proxy class for Events which handles paging differently, based on the current Event API
Contributor
|
@shevron I've rounded out the PR with tests. Thanks for contributing. As it happens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that
find_all()was missing fromintercom.events. In order to add it, I had to introduce a slightly different paging behavior (not sure why this API inconsistency).The least obtrusive way I found to do this was to allow overriding the
CollectionProxyclass forFindAlland to create a dedicatedCollectionProxysubclass for events which overridespaging_info_present.It works well for me, I hope that for others this will be useful as well.