Parse path from full url in extract_next_link#121
Closed
jfeldstein wants to merge 12 commits intointercom:version-3from
Closed
Parse path from full url in extract_next_link#121jfeldstein wants to merge 12 commits intointercom:version-3from
jfeldstein wants to merge 12 commits intointercom:version-3from
Conversation
Contributor
|
@jfeldstein Thanks for contributing. v2 is being retired in favour of v3. I see some activity on this project recently, so I'm going to get v3 published and we can work from there. |
intercom/collection_proxy.py
Outdated
| # Do this by re-applying the finder_params to the next_page url, since | ||
| # Intercom's API seems to drop these | ||
| from urlparse import urlparse, parse_qs, urlunparse | ||
| from urllib import urlencode |
Contributor
|
@jfeldstein I've just merged #125 into version-3 which provides this functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #120