Fix installation into an empty environment.#12
Closed
vrachnis wants to merge 1 commit intointercom:masterfrom
vrachnis:patch-1
Closed
Fix installation into an empty environment.#12vrachnis wants to merge 1 commit intointercom:masterfrom vrachnis:patch-1
vrachnis wants to merge 1 commit intointercom:masterfrom
vrachnis:patch-1
Conversation
Fix installation into an empty environment. Installing python-intercom in an empty virtualenv would fail because it was trying to import the requests package inside intercom/intercom.py. To properly fix this, the intercom/__init__.py file must be reorganized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick fix for installing python-intercom in an empty virtualenv. Without this change, it would fail because it was trying to import the requests package inside intercom/intercom.py before the installation was actually done.
I know that this pull request negates 17ad380, but i think that being able to install the package is more important.
To properly fix this, the intercom/init.py file should be reorganized to avoid importing extra modules.