Change id to user_id in user creation example#119
Closed
fscofield wants to merge 1 commit intointercom:masterfrom
Closed
Change id to user_id in user creation example#119fscofield wants to merge 1 commit intointercom:masterfrom
id to user_id in user creation example#119fscofield wants to merge 1 commit intointercom:masterfrom
Conversation
Creating a user with the `id` parameter as currently shown in the API does not actually save the input value - the `id` parameter is assigned by intercom and is not mutable. The documentation should instead use `user_id` in it's user creation example.
Merged
Contributor
|
Thanks @fscofield, I've merged on version-3 branch, so when it comes the time to update the docs the correct v2 code will guide the way. See #129 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a user with the
idparameter as currently shown in the API does not actually save the input value - theidparameter is assigned by intercom and is not mutable. The documentation should instead useuser_idin it's user creation example.