Skip to content

Add interface support for opens, closes, and assignments#101

Merged
jkeyes merged 1 commit intointercom:masterfrom
bobjflong:BL/conversations
Aug 12, 2015
Merged

Add interface support for opens, closes, and assignments#101
jkeyes merged 1 commit intointercom:masterfrom
bobjflong:BL/conversations

Conversation

@bobjflong
Copy link
Copy Markdown
Contributor

We recently added support for assigning, opening, and closing conversations: https://doc.intercom.io/api/#replying-to-a-conversation

We've also released updated versions of the Go, Java, Ruby, and PHP libraries. Be good to get nice support in here too!

@bobjflong
Copy link
Copy Markdown
Contributor Author

Seems like the coveralls doesn't check for integration specs (which is where the other conversations specs seemed to be located)

@jkeyes
Copy link
Copy Markdown
Contributor

jkeyes commented Aug 11, 2015

Having a look at this now @bobjflong. Thanks.

@jkeyes
Copy link
Copy Markdown
Contributor

jkeyes commented Aug 11, 2015

@bobjflong The integration tests run against the real API, that's why you need to specify the APP_ID and the API_KEY before running them. That's why they don't run as part of the Travis build and therefore coveralls can't see the coverage results.

@jkeyes
Copy link
Copy Markdown
Contributor

jkeyes commented Aug 11, 2015

@bobjflong The integration tests are to mirror the functionality covered in the README. It's really the sanity test for the library, and allows us to check that the Intercom side is behaving as documented.

@bobjflong
Copy link
Copy Markdown
Contributor Author

Hi @jkeyes thanks - is there anything I should do his to get this merge-able?

@jkeyes
Copy link
Copy Markdown
Contributor

jkeyes commented Aug 12, 2015

@bobjflong I'll merge it as is. I've work to do on version 3 which will bring it into line with the current intercom-ruby, and I'll move things around as need be then. Did a customer request this?

@bobjflong
Copy link
Copy Markdown
Contributor Author

@jkeyes it's definitely been a commonly requested set of features, and quite popular since launch.

jkeyes added a commit that referenced this pull request Aug 12, 2015
Add interface support for opens, closes, and assignments
@jkeyes jkeyes merged commit 569c6e2 into intercom:master Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants