[feature] handle 504 response#503
Merged
jonnyom merged 1 commit intointercom:masterfrom Nov 12, 2019
truecoach:bugfix/handle-504-error
Merged
[feature] handle 504 response#503jonnyom merged 1 commit intointercom:masterfrom truecoach:bugfix/handle-504-error
jonnyom merged 1 commit intointercom:masterfrom
truecoach:bugfix/handle-504-error
Conversation
jonnyom
reviewed
Nov 11, 2019
lib/intercom/version.rb
Outdated
| @@ -1,3 +1,3 @@ | |||
| module Intercom #:nodoc: | |||
| VERSION = "3.9.3" | |||
| VERSION = "3.10.0" | |||
Contributor
There was a problem hiding this comment.
Do you mind if we leave this change and then bump in a separate PR?
Modifying this version here affects the automatic bump command that we use when bundling releases 😄
Default handling for unexpected response bodies ([here](#492)) has revealed an unhandled 504 response from intercom. Example message from UnexpectedResponseError: ``` Intercom::UnexpectedResponseError, Expected a JSON response body. Instead got '<html> <head><title>504 Gateway Time-out</title></head> <body bgcolor="white"> <center><h1>504 Gateway Time-out</h1></center> </body> </html> ' with status code '504'. ```
Contributor
Author
|
@jonnyom Removed the version bump. Ready for re-review. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #502
Default handling for unexpected response bodies (here)
has revealed an unhandled 504 response from intercom.
Example message from UnexpectedResponseError: