Adding support for multi-page results for Event.find_all.#318
Merged
kant01ne merged 1 commit intointercom:masterfrom Feb 9, 2017
Merged
Adding support for multi-page results for Event.find_all.#318kant01ne merged 1 commit intointercom:masterfrom
kant01ne merged 1 commit intointercom:masterfrom
Conversation
Contributor
|
Lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While examining a PR for python-intercom I noticed that intercom-ruby doesn't support multi-page results for `Event.find_all.
The API paging support for Events differs to that for the other resources, which means
paging_info_presentwill always returnfalseas there is notypeattribute.I'm unfamiliar with Ruby, so I hope this PR will prove useful.