Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: intercom/intercom-php
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: intercom/intercom-php
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: anas/pagination-fixes
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Feb 11, 2017

  1. Fix the example code snippet in README.md about pagination. 

    The response returned from the API methods is decoded into an object of stdClass and not an associative array. Therefore, Current example was resulting in "Fatal error: Cannot use object of type stdClass as array"
    Muhammad Anas authored and Skaelv committed Feb 11, 2017
    Configuration menu
    Copy the full SHA
    691e11f View commit details
    Browse the repository at this point in the history

  2. Fix another fatal error while fetching the next page of a result set. 

    Fatal error: Cannot use object of type stdClass as array in src\IntercomClient.php on line 117
    Muhammad Anas authored and Skaelv committed Feb 11, 2017
    Configuration menu
    Copy the full SHA
    b7b6399 View commit details
    Browse the repository at this point in the history

  3. Update pagination test to reflect real structure returned by Intercom… 

    …Client::handleRequest()
    Muhammad Anas authored and Skaelv committed Feb 11, 2017
    Configuration menu
    Copy the full SHA
    a28aa50 View commit details
    Browse the repository at this point in the history
Loading