Skip to content
This repository was archived by the owner on Aug 7, 2025. It is now read-only.

Conversation

@berndgassmann
Copy link
Contributor

@berndgassmann berndgassmann commented Nov 5, 2021

Fixed ad_rss_map_integration python binding build failed in CARLA
environment because of not existing folder beeing referenced

Change-Id: Ida59d2d75f0420106d157fc49f0575130ea0a7e6

Description

Fixes #

Where has this been tested?

  • Platform(s): ...
  • Library version: ...

Possible Drawbacks


This change is Reviewable

Fixed ad_rss_map_integration python binding build failed in CARLA
environment because of not existing folder beeing referenced

Change-Id: Ida59d2d75f0420106d157fc49f0575130ea0a7e6
fabianoboril
fabianoboril previously approved these changes Nov 5, 2021
Copy link

@fabianoboril fabianoboril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @berndgassmann)

Use ubuntu's libproj version
fabianoboril
fabianoboril previously approved these changes Nov 8, 2021
Copy link

@fabianoboril fabianoboril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @berndgassmann)

Copy link

@fabianoboril fabianoboril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @berndgassmann)

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.06%. Comparing base (2ce3bc8) to head (3763eae).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   82.01%   82.06%   +0.05%     
==========================================
  Files         268      268              
  Lines       34826    34763      -63     
  Branches     6399     6384      -15     
==========================================
- Hits        28561    28527      -34     
+ Misses        805      783      -22     
+ Partials     5460     5453       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@berndgassmann berndgassmann merged commit 438ac2b into master Nov 8, 2021
@berndgassmann berndgassmann deleted the fix_python_binding_build branch November 8, 2021 17:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants