You're doing good work!

I'm wondering if there are patterns from #2958 you should be copying here (for example the conditions and rules validation)

You're doing good work!

Thanks! although I wasted a lot of time today being utterly confused of what is actually implemented and exposed in the API/golang sdk. E.g there are parts in the go sdk, which indicate that a ruleset can use the new repository_properties, organization_properties or merge_queue, but the actual API of the Enterprise Cloud is not supporting it 🔥

I'm wondering if there are patterns from #2958 you should be copying here (for example the conditions and rules validation)

I can check it out and see if I can adjust it !

#3110 (comment)

For the importer feature: I left it out intentionally as I was under the impression it is a feature used only in UI. Not sure who actually would use it with terraform/tofu to import json in hcl.

I'm wondering if there are patterns from #2958 you should be copying here (for example the conditions and rules validation)

Similar to the the CustomizeDiff in #2958 I've added the util_ruleset_enterprise_validation.go to validate that:

• ref_name is required for branch/tag, but forbidden for push/repository
• creation, deletion, update, required_linear_history, required_signatures, pull_request, required_status_checks,
  non_fast_forward, commit_message_pattern, commit_author_email_pattern, committer_email_pattern, branch_name_pattern,
  tag_name_pattern, required_workflows, required_code_scanning, copilot_code_review rules are only valid for branch/tag
  targets
• file_path_restriction, max_file_size, max_file_path_length, file_extension_restriction rules are only valid for push
  target
• repository_creation, repository_deletion, repository_transfer, repository_name, repository_visibility rules are only
  valid for repository target

The Importer is functionality to enable terraform import or the import block inside the config, so that existing resources can be added to state

The Importer is functionality to enable terraform import or the import block inside the config, so that existing resources can be added to state

Oh nevermind, yes that I will most definitely add!

I thought you were referring to the importer functionality in GitHub rulesets. Oops

The Importer is functionality to enable terraform import or the import block inside the config, so that existing resources can be added to state

7dd2b13

Added the importer functionality + test

TF_CLI_CONFIG_FILE=../dev.tfrc terraform import github_enterprise_ruleset.imported siemens:440187
github_enterprise_ruleset.imported: Importing from ID "siemens:440187"...
github_enterprise_ruleset.imported: Import prepared!
  Prepared github_enterprise_ruleset for import
github_enterprise_ruleset.imported: Refreshing state... [id=440187]

Import successful!