[BUG] Repository creation as archived would fail#3084
[BUG] Repository creation as archived would fail#3084deiga wants to merge 6 commits intointegrations:mainfrom
archived would fail#3084Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
...and skips further updates to the repository Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
deiga
force-pushed
the
fix-repo-creation-as-archived
branch
from
bf12956 to
63bca10
Compare
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
@deiga could we not just add a diff check function and disable the creation of archived repositories full stop? We could re-visit the functionality once the repository resource has been refactored.
On a separate note, the repository resource really needs to be refactored to avoid the calling of create -> update -> read or update -> read.
Yes please to the latter. Fair point to the former. I'll need to revisit this PR as my solution probably didn't consider "what should we allow" |
|
@deiga do you already have an issue tracking the refactoring work? |
@stevehipwell Not for the whole repo changes, just the vulnerability alerts |
2 participants
Before the change?
github_repositoryresource witharchived = trueandvisibility = "private"would fail with 403After the change?
github_repositoryresource witharchived = truewill "stop" execution inCreateto only setarchivedon the repo.Pull request checklist
Schema migrations have been created if needed (example)Does this introduce a breaking change?
Please see our docs on breaking changes to help!