feat: add enterprise (inherited) runner group org setting resource by coopernetes · Pull Request #3080 · integrations/terraform-provider-github

coopernetes · 2026-01-15T18:46:20Z

Add new resource github_enterprise_actions_runner_group_org_settings.

This resource allows managing organization-level settings for enterprise
Actions runner groups that are inherited by an organization. It configures
various org-specific settings such as allowed repositories, visibility and
workflow restrictions. The existing org-level resource assumes that an
organization runner group is to be created & fully managed by Terraform so
it does not work for an enterprise-scope group that is shared with one or
more organizations within a GitHub Enterprise environment.

Resolves #2768 (#2768)

Before the change?

N/A, this is a new resource and new behaviour in the provider.

After the change?

A new resource called github_enterprise_actions_runner_group_org_settings can be created
to manage an enterprise-scoped, inherited runner group for a GitHub organization. Note that a pre-requisite resource github_enterprise_actions_runner_group is required and is depended on existing before org settings can be created & managed.

Pull request checklist

Schema migrations have been created if needed (example)
Tests for the changes have been added (for bug fixes / features)
Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

Yes
No

This resource allows managing organization-level settings for enterprise Actions runner groups that are inherited by an organization. It configures various org-specific settings such as allowed repositories, visibility and workflow restrictions. The existing org-level resource assumes that an organization runner group is to be created & fully managed by Terraform so it does not work for an enterprise-scope group that is shared with one or more organizations within a GitHub Enterprise environment. Closes integrations#2768

github-actions · 2026-01-15T18:46:40Z

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

deiga · 2026-01-15T20:55:41Z

Thanks for opening a PR!

~~Considering this, I wonder if it would make sense to just add some options to the existing resource 🤔~~

~~What do you think?~~

I was proven wrong, separate resources are better

deiga · 2026-01-18T21:09:50Z

github/resource_github_enterprise_actions_runner_group_org_settings.go

+		Create: resourceGithubEnterpriseActionsRunnerGroupOrgSettingsCreate,
+		Read:   resourceGithubEnterpriseActionsRunnerGroupOrgSettingsRead,
+		Update: resourceGithubEnterpriseActionsRunnerGroupOrgSettingsUpdate,
+		Delete: resourceGithubEnterpriseActionsRunnerGroupOrgSettingsDelete,
+		Importer: &schema.ResourceImporter{
+			State: resourceGithubEnterpriseActionsRunnerGroupOrgSettingsImport,


issue: Please use Context-aware provider functions

deiga · 2026-01-18T21:10:06Z

github/resource_github_enterprise_actions_runner_group_org_settings.go

+		Importer: &schema.ResourceImporter{
+			State: resourceGithubEnterpriseActionsRunnerGroupOrgSettingsImport,
+		},
+


Please add a top-level Description field

deiga · 2026-01-18T21:11:46Z

github/provider.go

 			"github_enterprise_actions_runner_group":                                resourceGithubActionsEnterpriseRunnerGroup(),
 			"github_enterprise_actions_workflow_permissions":                        resourceGithubEnterpriseActionsWorkflowPermissions(),
 			"github_actions_organization_workflow_permissions":                      resourceGithubActionsOrganizationWorkflowPermissions(),
+			"github_enterprise_actions_runner_group_org_settings":                   resourceGithubEnterpriseActionsRunnerGroupOrgSettings(),


I'm not a fan of using abbreviations in the resource names, what about something like resource_github_organization_inherited_runner_group_settings?

deiga · 2026-01-18T21:22:36Z

github/resource_github_enterprise_actions_runner_group_org_settings.go

+			"enterprise_runner_group_name": {
+				Type:        schema.TypeString,
+				Required:    true,
+				ForceNew:    true,


I'm not sure if ForceNew here is correct, since the name of a runner group can change without changing the ID. Maybe this should instead have a CustomizeDiff function which checks if name was changed AND runner_group_id changed => ForceNew

deiga · 2026-01-18T21:27:06Z

github/resource_github_enterprise_actions_runner_group_org_settings.go

+
+		for _, group := range groups.RunnerGroups {
+			// Only match runner groups that are inherited from the enterprise
+			if group.GetName() == name && group.GetInherited() {


suggestion: A minor optimization would be to swat the conditions here. Checking GetInherited() first should be "cheaper" than doing a string comparison

deiga · 2026-01-18T21:38:15Z

github/resource_github_enterprise_actions_runner_group_org_settings.go

+}
+
+func resourceGithubEnterpriseActionsRunnerGroupOrgSettingsImport(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) {
+	parts := strings.Split(d.Id(), ":")


Suggested change

parts := strings.Split(d.Id(), ":")

org, identifier, err := parseID2(d.Id())

deiga · 2026-01-18T21:40:05Z

github/resource_github_enterprise_actions_runner_group_org_settings.go

+func resourceGithubEnterpriseActionsRunnerGroupOrgSettingsImport(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) {
+	parts := strings.Split(d.Id(), ":")
+	if len(parts) != 2 {
+		return nil, fmt.Errorf("invalid import ID format, expected 'organization:enterprise_runner_group_name' or 'organization:runner_group_id'")


The user needs to understand that they can't use the runner group ID from the enterprise, but the Org. They are different 😬

Suggested change

return nil, fmt.Errorf("invalid import ID format, expected 'organization:enterprise_runner_group_name' or 'organization:runner_group_id'")

return nil, fmt.Errorf("invalid import ID format, expected 'organization:enterprise_runner_group_name' or 'organization:organization_runner_group_id'")

deiga · 2026-01-18T21:40:55Z

github/resource_github_enterprise_actions_runner_group_org_settings_test.go

+	if isEnterprise != "true" {
+		t.Skip("Skipping because `ENTERPRISE_ACCOUNT` is not set or set to false")
+	}
+
+	if testEnterprise == "" {
+		t.Skip("Skipping because `ENTERPRISE_SLUG` is not set")
+	}
+
+	if testOrganization == "" {
+		t.Skip("Skipping because `GITHUB_ORGANIZATION` is not set")
+	}


Please use the new skipUnless* functions, you don't need to worry about checking these fields

Suggested change

if isEnterprise != "true" {

t.Skip("Skipping because `ENTERPRISE_ACCOUNT` is not set or set to false")

}

if testEnterprise == "" {

t.Skip("Skipping because `ENTERPRISE_SLUG` is not set")

}

if testOrganization == "" {

t.Skip("Skipping because `GITHUB_ORGANIZATION` is not set")

}

deiga · 2026-01-18T21:41:26Z

github/resource_github_enterprise_actions_runner_group_org_settings_test.go

+
+			# Create a test repository
+			resource "github_repository" "test" {
+				name        = "tf-acc-test-repo-%s"


Please use testResourcePrefix to generate the repo name

deiga · 2026-01-18T21:41:50Z

github/resource_github_enterprise_actions_runner_group_org_settings_test.go

+		t.Run("with an enterprise account", func(t *testing.T) {
+			testCase(t, enterprise)
+		})


This structure is no longer supported

Suggested change

t.Run("with an enterprise account", func(t *testing.T) {

testCase(t, enterprise)

})

deiga suggested changes Jan 18, 2026

View reviewed changes

deiga added Type: Feature New feature or request New resource Awaiting response labels Jan 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add enterprise (inherited) runner group org setting resource#3080

feat: add enterprise (inherited) runner group org setting resource#3080
coopernetes wants to merge 1 commit intointegrations:mainfrom
RBC:2768-ent-runner-org-resource

coopernetes commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

deiga commented Jan 15, 2026 •

edited

Loading

Uh oh!

deiga Jan 18, 2026

Uh oh!

deiga Jan 18, 2026

Uh oh!

deiga Jan 18, 2026

Uh oh!

deiga Jan 18, 2026

Uh oh!

deiga Jan 18, 2026

Uh oh!

deiga Jan 18, 2026

Uh oh!

deiga Jan 18, 2026

Uh oh!

deiga Jan 18, 2026

Uh oh!

deiga Jan 18, 2026

Uh oh!

deiga Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	parts := strings.Split(d.Id(), ":")
	org, identifier, err := parseID2(d.Id())

	return nil, fmt.Errorf("invalid import ID format, expected 'organization:enterprise_runner_group_name' or 'organization:runner_group_id'")
	return nil, fmt.Errorf("invalid import ID format, expected 'organization:enterprise_runner_group_name' or 'organization:organization_runner_group_id'")

	t.Run("with an enterprise account", func(t *testing.T) {
	testCase(t, enterprise)
	})

Conversation

coopernetes commented Jan 15, 2026

Before the change?

After the change?

Pull request checklist

Does this introduce a breaking change?

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

deiga commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

deiga commented Jan 15, 2026 •

edited

Loading