Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
stevehipwell
force-pushed
the
team-slug
branch
from
12f7b74 to
9e8efec
Compare
deiga
left a comment
deiga
left a comment
There was a problem hiding this comment.
Just did a pass to see what you are up to. Ignore any comments that aren't applicable
| "team_slugs": { | ||
| Type: schema.TypeSet, | ||
| Optional: true, | ||
| MaxItems: 6, |
There was a problem hiding this comment.
Do you think we could add validation that none of these fields together are more than 6? AFAIK the API will fail with 422 or possibly silently fail 😬
There was a problem hiding this comment.
Good point, yes we should be able to add a diff function to handle the check for the aggregate count.
|
|
||
| func resourceGithubTeamCreate(ctx context.Context, d *schema.ResourceData, meta any) diag.Diagnostics { | ||
| err := checkOrganization(meta) | ||
| func resourceGithubTeamCreate(ctx context.Context, d *schema.ResourceData, m any) diag.Diagnostics { |
There was a problem hiding this comment.
question: what's the benefit of this change?
There was a problem hiding this comment.
We get a typed meta var that we can pass around and fewer casts in the code. Note that in the framework the provider data is typed so this is tending towards consistency.
2 participants
Resolves #3044
Resolves #3052
Resolved #2874
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!