feat: add github_enterprise_actions_hosted_runner#3017
feat: add github_enterprise_actions_hosted_runner#3017nico34638 wants to merge 3 commits intointegrations:mainfrom
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
|
Hey @nico34638 👋 Thank you very much for your contribution! We're currently working on a major release of the provider and that will possibly delay getting this PR merged. While that's happening, could I bother you for a few changes?
Support for Hosted runners for enterprises was added in v70 of go-github. Our upcoming major release will upgrade to v77. Could you rebase your branch on top of #2891 and use the SDK methods instead of manual HTTP requests? :) |
|
Okay, I made the changes you requested. I rebased on your branch with go github/v77 and changed the description fields. Is that okay with you? I tested it, and with the changes, it still works. |
|
Hey @nico34638 |
|
Hey @deiga, It's done. Do you have any idea when the provider's next release will be? |
github/resource_github_enterprise_actions_hosted_runner_test.go
Outdated
Show resolved
Hide resolved
github/resource_github_enterprise_actions_hosted_runner_test.go
Outdated
Show resolved
Hide resolved
deiga
left a comment
There was a problem hiding this comment.
Please ensure the test structure follows the current pattern
github/resource_github_enterprise_actions_hosted_runner_test.go
Outdated
Show resolved
Hide resolved
github/resource_github_enterprise_actions_hosted_runner_test.go
Outdated
Show resolved
Hide resolved
github/resource_github_enterprise_actions_hosted_runner_test.go
Outdated
Show resolved
Hide resolved
36951d4 to
9ac9b53
Compare
|
I have corrected the comments |
|
Hi @deiga do you any news ? |
stevehipwell
left a comment
There was a problem hiding this comment.
Thanks for the PR @nico34638, I've added some initial review comments.
| * Runner creation and updates may take several minutes as GitHub provisions the infrastructure. | ||
| * Static public IPs are subject to account limits. Check your enterprise's limits before enabling. | ||
|
|
||
| ## Getting Available Images and Sizes |
There was a problem hiding this comment.
Why not add a data source for this?
There was a problem hiding this comment.
I can do this in the same PR ?
github/resource_github_enterprise_actions_hosted_runner_test.go
Outdated
Show resolved
Hide resolved
|
Following the last review, I'm taking this opportunity to add two data sources for hosted enterprise runners: |
Resolves #3016
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!