Pull request overview

This PR adds comprehensive support for GitHub Enterprise Cost Centers, enabling Terraform management of cost center resources and their assignments. The implementation addresses issue #2739 by leveraging the newly public GitHub Enterprise billing API.

Key changes:

• Introduces github_enterprise_cost_center resource for creating, updating, and archiving cost centers with authoritative management of user, organization, and repository assignments
• Adds github_enterprise_cost_center and github_enterprise_cost_centers data sources for querying cost center information
• Implements robust resource assignment synchronization with batching (50 resources per request) and retry logic for transient failures

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Half-way through. Please consider if my comments could apply to other places in your changes as well, I wasn't able to comment on every duplicate thing

Thank you for the thorough review @deiga! I've addressed all the feedback. Here's a summary of the changes:

Implemented:

• ✅ Added top-level Description attribute to all resources and data sources
• ✅ Removed ctx = context.WithValue(ctx, ctxId, ...) pattern from all files
• ✅ Replaced log.Printf with tflog.Info and added tflog.Warn for 404 removals
• ✅ Used diag.Errorf instead of diag.FromErr(fmt.Errorf(...))
• ✅ Create and Update no longer call Read - computed fields are set directly
• ✅ Extracted anonymous retry functions to named functions (retryCostCenterAddResources, retryCostCenterRemoveResources)
• ✅ Changed import ID separator from / to : and using parseTwoPartID
• ✅ Replaced stringSliceToAnySlice with existing flattenStringList
• ✅ Used http.StatusNotFound and other constants instead of magic numbers
• ✅ Moved is404 to util.go
• ✅ Updated tests to use providerFactories and skipUnlessEnterprise(t)
• ✅ Added owner = var.enterprise_slug to example provider config
• ✅ Used buildTwoPartID in data source
• ✅ Inlined check variables in tests

Regarding questions:

• The resources attribute provides the raw API view while users, organizations, repositories are filtered convenience attributes. I kept both for flexibility and debugging purposes.
• diffStringSlices differs from setChanges - it compares string slices directly while setChanges works with Terraform state changes. They serve different purposes.
• In Create, we only fetch from API after assignments are configured to populate computed fields, since we're not calling Read anymore.

All tests pass and the code compiles without errors.

Please pay attention to what I'm asking form you and make sure to make similar changes in other places where they might apply.

Consider these also for your other PRs

LGTM, still need review from other maintainers

Thanks for the PR @vmvarela, I've added some general comments.

But my main review comment is that the pattern you're attempting to use for github_enterprise_cost_center is mixing concerns. Could you please separate out the assignments from the github_enterprise_cost_center resource. You could create a github_enterprise_cost_center_assignment resource to keep the authoritative pattern if it needs to span all types; but github_enterprise_cost_center_users, github_enterprise_cost_center_organizations & github_enterprise_cost_center_repositories would be the preferred pattern. This way the provider logic is more consistent and we could support non-authoritative patterns in the future.