Skip to content

Remove trailing spaces and empty contexts from yaml#71

Merged
vishnoianil merged 2 commits intoinstructlab:mainfrom
nerdalert:yaml-trailing
Jul 12, 2024
Merged

Remove trailing spaces and empty contexts from yaml#71
vishnoianil merged 2 commits intoinstructlab:mainfrom
nerdalert:yaml-trailing

Conversation

@nerdalert
Copy link
Member

@nerdalert nerdalert commented Jul 12, 2024

  • Custom yaml for multiline white spaces.
  • Single line will single quote by default.
  • If the context field is null, do not add it to the skill yaml.

Closes #70
Closes #72

Example output: https://github.com/brents-pet-robot/taxonomy-sub-testing/pull/139/files

- Custom yaml for multiline white spaces.
- Single line will single quote by default.

Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
@nerdalert nerdalert changed the title Remove trailing spaces from yaml Remove trailing spaces and empty contexts from yaml Jul 12, 2024
@nerdalert nerdalert requested a review from vishnoianil July 12, 2024 03:57
Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnoianil vishnoianil merged commit 3e4a649 into instructlab:main Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If a Skill context is empty, do not include it in the submission Trim trailing yaml whitespaces

2 participants