Skip to content

Added alert to login page for invalid github token#674

Merged
vishnoianil merged 1 commit intoinstructlab:mainfrom
elkielki:issue454
Mar 26, 2025
Merged

Added alert to login page for invalid github token#674
vishnoianil merged 1 commit intoinstructlab:mainfrom
elkielki:issue454

Conversation

@elkielki
Copy link
Collaborator

@elkielki elkielki commented Mar 18, 2025

I added an inline error message to the login page for an invalid github token as shown in the image. Fixes #454

@elkielki elkielki force-pushed the issue454 branch 2 times, most recently from abadb8e to 4d7f302 Compare March 18, 2025 02:27
Signed-off-by: elkielki <ekim2817@gmail.com>
Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnoianil vishnoianil merged commit 1f8aa26 into instructlab:main Mar 26, 2025
5 checks passed
@vishnoianil
Copy link
Member

Fixes #454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If OAuth fails, redirect to a useful error page

2 participants