Skip to content

Updates to Login page#665

Merged
vishnoianil merged 1 commit intoinstructlab:mainfrom
jeff-phillips-18:login-page-updates
Mar 17, 2025
Merged

Updates to Login page#665
vishnoianil merged 1 commit intoinstructlab:mainfrom
jeff-phillips-18:login-page-updates

Conversation

@jeff-phillips-18
Copy link
Collaborator

@jeff-phillips-18 jeff-phillips-18 commented Mar 14, 2025

Description

Updates the Login page per UX review

  • Update text
  • Update loading state
  • Remove dev login variant

Screen shots

Loading

LoginLoading

Github mode

image

Native mode

image

Native mode - failed login

image

/cc @Misjohns

@jeff-phillips-18 jeff-phillips-18 force-pushed the login-page-updates branch 2 times, most recently from ba85854 to bd848e8 Compare March 14, 2025 15:02
Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Misjohns
Copy link
Collaborator

@vishnoianil There a little cleanup for the Native mode. We need consistent padding so elements look more centered in the space between left edge and the graphic. Move login elements 60px from left edge.
image

@vishnoianil
Copy link
Member

vishnoianil commented Mar 17, 2025

@vishnoianil There a little cleanup for the Native mode. We need consistent padding so elements look more centered in the space between left edge and the graphic. Move login elements 60px from left edge. image

Hi @Misjohns In my testing locally, i see the login page as follows

Login-Page

Signed-off-by: Jeffrey Phillips <jephilli@redhat.com>
@jeff-phillips-18
Copy link
Collaborator Author

@Misjohns Updated:

image

@vishnoianil vishnoianil merged commit 7231c94 into instructlab:main Mar 17, 2025
5 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the login-page-updates branch March 18, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants