@Bhas-kar the UI lint job is failing, can you please run npm run pretty and npm run lint:fix locally on your branch and push the changes.

Hi @vishnoianil ,

I have fixed the UI lint job failure.
requesting to kindly re review the same.

thanks

@Bhas-kar The PR looks good. But seems like the commit history got messed up (16 commits). Can you please fix the commit history. Pull the latest main and rebase your branch over the latest main, that should fix it.

@Bhas-kar The PR looks good. But seems like the commit history got messed up (16 commits). Can you please fix the commit history. Pull the latest main and rebase your branch over the latest main, that should fix it.

Hey @vishnoianil
rebased my branch, the commits issue seems resolved now.
thanks

hey @vishnoianil and @jeff-phillips-18 ,
could you please review the PR
thanks

@Bhas-kar Could you please squash your commits and rebase such that you don't require a merge commit?

@Bhas-kar Could you please squash your commits and rebase such that you don't require a merge commit?

rebased the branch as suggested, thanks @jeff-phillips-18

Screen shot:

/cc @Misjohns

@jeff-phillips-18 Why are we adding the username and password fields? I missed those requirements being added. If we do need them then we need a little tweaking. Reach out if you'd like to discuss further.

• Hierarchy is off. Typically we place the traditional login first, followed by the alternatives (ie. GitHub)
  -- The secondary login (GitHub) should be treated as a secondary button so let's outline the button.
  -- Let's discuss if we really need the GH login first. Otherwise, please follow mockup.
  -- Need to group the actions beneath the appropriate button (forgot username or password beneath primary login button, New to GH? beneath GH login)
• The username and password fields are black so a user won't be able to see them.
• The blue login button doesn't pass contrast requirements so that'll need to be black.

@Misjohns Sorry, the username/password is only necessary in dev mode. I should have given the latest from non-dev mode:

• The blue login button doesn't pass contrast requirements so that'll need to be black.

@Misjohns We have 3 modes that we support.

• Github mode (ui.instructlab/qa.ui.instructlab) - That only supports github login.
• Native model - It only supports username/password because github login is not required there, given that everything is contributed locally.
• Dev Mode - That mode is only for developer to test both of these modes, and that's where they can use username/password or github login both, but that's only for developer. I am thinking of getting rid of this page, because dev's can use the respective login page of these modes and doesn't really require this third mode.

Let me know if you need any more details around it.