@jeff-phillips-18 Thanks for the PR, overall it looks good.

Few minor issues i found during my testing

• When you "Add Seed Example" it adds the Knowledge seed example (1 context and 2 QnA pair)
• Due to this, review submission also shows the same knowledge seed example
• It shows context limit to 500 words but skill form actually has no limit when it comes to context.
• Although the help text for context says it's option, but it shows error if you don't fill the context.
• For skills, context is option, so it would probably be better if we show it after the QnA Pair
• "Upload skill yaml file" feature is failing because it's not able to recognize the json in Skill schema, mostly because we are now using a same data structure for both skill and knowledge.
• It doesn't display "Yaml content" when i click on Yaml Content from drop down

Cannot read properties of undefined (reading 'split')
    at convertToYaml (SkillWizard.tsx:210:42)

• It does show attribution content, but the "Download" button is not working.
• Skill gets submitted successfully, and after that it shows the new skill form, but the Author Information is not auto filled. I think once user submit the skill we should direct user to the dashboard itself.

@jeff-phillips-18 Thanks for the PR, overall it looks good.

Few minor issues i found during my testing

• When you "Add Seed Example" it adds the Knowledge seed example (1 context and 2 QnA pair)
• Due to this, review submission also shows the same knowledge seed example

These first two have already been fixed.

• It shows context limit to 500 words but skill form actually has no limit when it comes to context.
• Although the help text for context says it's option, but it shows error if you don't fill the context.

This has already been fixed

• For skills, context is option, so it would probably be better if we show it after the QnA Pair
• "Upload skill yaml file" feature is failing because it's not able to recognize the json in Skill schema, mostly because we are now using a same data structure for both skill and knowledge.
• It doesn't display "Yaml content" when i click on Yaml Content from drop down

Cannot read properties of undefined (reading 'split')
    at convertToYaml (SkillWizard.tsx:210:42)

• It does show attribution content, but the "Download" button is not working.
• Skill gets submitted successfully, and after that it shows the new skill form, but the Author Information is not auto filled. I think once user submit the skill we should direct user to the dashboard itself.

I'm working on these others

• Skill gets submitted successfully, and after that it shows the new skill form, but the Author Information is not auto filled. I think once user submit the skill we should direct user to the dashboard itself.

@vishnoianil If we do this the user never sees the notification of the new PR created and doesn't get the link to it. I think we should auto fill the author info again. WDYT?

• Skill gets submitted successfully, and after that it shows the new skill form, but the Author Information is not auto filled. I think once user submit the skill we should direct user to the dashboard itself.

@vishnoianil If we do this the user never sees the notification of the new PR created and doesn't get the link to it. I think we should auto fill the author info again. WDYT?

Sounds good.

@jphillips PR is very close to be perfect now :). All the above listed issues are resolved now.

Found few minor issues with the latest patch:

• Knowledge form shows 5 QnA pairs now, it should be 3.
• Skill "Seed Example" step is failing validation. Context is optional but i tested it with context as well, but still validation fails.
• Download the attribution file (in github mode), shows file name as (skill) and it saves the file with the "yaml" extension. The filename should be attribution.txt. The same happens for knowledge attribution file as well. For knowledge contribution also the filename should be attribution.txt. Although the content of the file looks good.