Skip to content

Fixes for Attribution step status and filling input box on context selection from a file#620

Merged
vishnoianil merged 2 commits intoinstructlab:mainfrom
jeff-phillips-18:fixes
Feb 25, 2025
Merged

Fixes for Attribution step status and filling input box on context selection from a file#620
vishnoianil merged 2 commits intoinstructlab:mainfrom
jeff-phillips-18:fixes

Conversation

@jeff-phillips-18
Copy link
Collaborator

Description

  • Adds a fix to set the status for the Attribution step in the knowledge wizard
  • Adds a fix to properly fill the context input area when selecting context from a file

@vishnoianil
Copy link
Member

@jeff-phillips-18 DCO job is still failing, you need to signoff both the commit to make it happy.

Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jeffrey Phillips <jephilli@redhat.com>
Signed-off-by: Jeffrey Phillips <jephilli@redhat.com>
@vishnoianil vishnoianil merged commit e2ac614 into instructlab:main Feb 25, 2025
5 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the fixes branch February 25, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants