Add a convert from URL server side rendered route#615
Merged
vishnoianil merged 1 commit intoinstructlab:mainfrom Mar 4, 2025
Merged
Add a convert from URL server side rendered route#615vishnoianil merged 1 commit intoinstructlab:mainfrom
vishnoianil merged 1 commit intoinstructlab:mainfrom
Conversation
- Provides the client side a server side route to send docling conversion requests from a URL source rather than file file sources. Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
Member
|
@nerdalert PR looks good to me. I think convert functions are specific to docling, and used by both github and native mode, so I think we should move convert and convert-http both out native to /api or /api/docling/? wdyt? |
vishnoianil
approved these changes
Mar 4, 2025
Member
vishnoianil
left a comment
There was a problem hiding this comment.
Had discussion with brent on this. Keeping this endpoint separate till we get end to end workflow working. Once we have a stable end to end workflow, we can possibly refactor and merge with convert api.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example usage from the client side:
cc/ @jeff-phillips-18