Updates to native Knowledge contribution wizard#596
Merged
vishnoianil merged 4 commits intoinstructlab:mainfrom Feb 25, 2025
Merged
Updates to native Knowledge contribution wizard#596vishnoianil merged 4 commits intoinstructlab:mainfrom
vishnoianil merged 4 commits intoinstructlab:mainfrom
Conversation
jeff-phillips-18
force-pushed
the
wizard-updates
branch
6 times, most recently
from
bb1e618 to
2d4e675
Compare
vishnoianil
reviewed
Feb 19, 2025
Member
vishnoianil
left a comment
vishnoianil
left a comment
There was a problem hiding this comment.
@jeff-phillips-18 Thanks for the PR. Error handling and button alignment looks great!
Notice few issues:
- Looks are attribution are removed in the github mode. It's required for github mode.
- Knowledge submission fails in github mode.
- Author information is not getting auto-populated for both github and native mode
- Seed example addition adds the seed example successfully, but delete is not working.
Signed-off-by: Jeffrey Phillips <jephilli@redhat.com>
Signed-off-by: Jeffrey Phillips <jephilli@redhat.com>
Signed-off-by: Jeffrey Phillips <jephilli@redhat.com>
jeff-phillips-18
force-pushed
the
wizard-updates
branch
from
2d4e675 to
0283c2e
Compare
Signed-off-by: Jeffrey Phillips <jephilli@redhat.com>
jeff-phillips-18
force-pushed
the
wizard-updates
branch
from
0283c2e to
c0e8956
Compare
vishnoianil
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards SME Submission Wizard Cleanup
Description
Make updates to the Knowledge contribution wizards
Screen shots
/cc @Misjohns @beaumorley @Mdenisco