Fixes DCO signoff issue#548
Merged
Gregory-Pereira merged 1 commit intoinstructlab:release-1.0from Feb 4, 2025
Merged
Conversation
Auth session keeps information from the user profile, so if the email address is not made visible on the profile or alias is set as an email address, UI was using that email address for signoff. In some cases, this was failing because that email address is not users primary email address. For DCO to pass, user needs to signoff the commits with it's primary email address set in his account. Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auth session keeps information from the user profile, so if the email address is not made visible on the profile or alias is set as an email address, UI was using that email address for signoff. In some cases, this was failing because that email address is not users primary email address.
For DCO to pass, user needs to signoff the commits with it's primary email address set in his account.