Merged
Conversation
RobotSail
approved these changes
Dec 6, 2024
Gregory-Pereira
force-pushed
the
umami-metrics-deployment
branch
from
da677f7 to
1ffe86e
Compare
Gregory-Pereira
changed the title
Closed
Gregory-Pereira
force-pushed
the
umami-metrics-deployment
branch
from
1ffe86e to
a76abda
Compare
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
… secret template, secrets applied individually Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Gregory-Pereira
force-pushed
the
umami-metrics-deployment
branch
from
fbbf830 to
5c7ecc1
Compare
Signed-off-by: greg pereira <grpereir@redhat.com>
Gregory-Pereira
force-pushed
the
umami-metrics-deployment
branch
3 times, most recently
from
e60da09 to
42c3a03
Compare
vishnoianil
reviewed
Dec 11, 2024
Member
There was a problem hiding this comment.
awesome work @Gregory-Pereira . Few minor comments. Can you add some text around how to access the umami dashboard in kind and openshift environment?
Also i think the PR description needs to be updated?
Gregory-Pereira
force-pushed
the
umami-metrics-deployment
branch
from
42c3a03 to
08441f9
Compare
Gregory-Pereira
force-pushed
the
umami-metrics-deployment
branch
from
08441f9 to
ac980b2
Compare
Collaborator
Author
|
I would consider your review addressed @vishnoianil. I did try to make the route changes you were talking about but they would require another refactor (swapping to ingress or something else). For that reason, lets keep a separate route for the umami portal disconnected from the UI domain. We can iterate as we go - I would love to eventually see it as tab in our UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses: #281
cc @RobotSail @vishnoianil @nerdalert
Changes:
kind.yamland thekind-ingress.yamland then deploying the umami stack. That being said I tried the same thing with the Instructlab-ui kind manifests, and the ingress for that also didn't work so I assume this is a non-issue.kinddocs on stuff I learned through struggling with itAfter this PR lands, we need to deploy it, make sure its working, and then go in and configure the settings. After that is done, we can setup a sites for QA and Prod, and grab their respective tracker codes to to embed in the TS codebase. Then we simply do check on the env variable and inject the correct script tag.