remove CI_AUTOMATION workflow errors by checking skip#378
Merged
Gregory-Pereira merged 1 commit intoinstructlab:mainfrom Dec 4, 2024
Merged
Conversation
Gregory-Pereira
force-pushed
the
cleanup-CI_AUTOMATION-failures-in-worfklow
branch
from
3e1e6df to
0816799
Compare
Member
|
@Gregory-Pereira This PR needs a rebase, i believe due to the merge of #363 |
Signed-off-by: greg pereira <grpereir@redhat.com>
Gregory-Pereira
force-pushed
the
cleanup-CI_AUTOMATION-failures-in-worfklow
branch
from
0816799 to
9eb3c80
Compare
Member
|
/LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently what is happening: A PR gets merged, which through CI triggers a commit to bump and push the deployment manifests with new updated image tag, which triggers the same workflow. At this point I previously chose to fail the workflow but that looks ugly in CI, as well as produces false positives for debugging - making me think some of those actions are actually failing and not just cutting short as intended. This code change should make it such the workflow still succeeds it would just only have 1 job. This is the only job that needs it as all the others either look for different push paths or are triggered on release.
cc @vishnoianil @nerdalert