initial devcontainer implementation#366
Merged
nerdalert merged 2 commits intoinstructlab:mainfrom Nov 21, 2024
Merged
Conversation
Signed-off-by: greg pereira <grpereir@redhat.com>
Collaborator
Author
|
This implementation is based off of the https://github.com/devcontainers/images/tree/main/src/typescript-node base image and its parent: https://github.com/devcontainers/images/tree/main/src/javascript-node, both of which have been properly rebased against the official redhat ubi9/nodejs image |
Gregory-Pereira
added
enhancement
UX
Gregory-Pereira
force-pushed
the
implement-devcontainer
branch
3 times, most recently
from
72e5c00 to
0c17a50
Compare
Signed-off-by: greg pereira <grpereir@redhat.com>
Gregory-Pereira
force-pushed
the
implement-devcontainer
branch
from
0c17a50 to
e271e91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #361
cc @vishnoianil @nerdalert
Everything works like a dream. I motion we publish this image to the quay org. Also if you think of any other cool binaries we could stuff in here that would be great. I was thinking maybe
ngrokif they want a free way to emulate HTTPS routes and share one devs build to another