Skip to content

removing -S tack from commit, signing requires ssh key#347

Merged
vishnoianil merged 1 commit intoinstructlab:mainfrom
Gregory-Pereira:fix-tagging-commit-signing-issue
Nov 17, 2024
Merged

removing -S tack from commit, signing requires ssh key#347
vishnoianil merged 1 commit intoinstructlab:mainfrom
Gregory-Pereira:fix-tagging-commit-signing-issue

Conversation

@Gregory-Pereira
Copy link
Collaborator

Next workflow failed due to lack of access to the actor's (whoever merges the MR) ssh key. Moving to just signoff but not ssh signature.

cc @vishnoianil @nerdalert

Signed-off-by: greg pereira <grpereir@redhat.com>
@Gregory-Pereira
Copy link
Collaborator Author

The good news is we can confirm that we are getting PR tags and quay attestations:

podman manifest inspect quay.io/instructlab-ui/ui:pr-346
{
    "schemaVersion": 2,
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "manifests": [
        {
            "mediaType": "application/vnd.oci.image.manifest.v1+json",
            "size": 2010,
            "digest": "sha256:90e8fb6d7f54fad7e6efc70492313d49771f3d3dbb27199cb7cac38d884638cd",
            "platform": {
                "architecture": "amd64",
                "os": "linux"
            }
        },
        {
            "mediaType": "application/vnd.oci.image.manifest.v1+json",
            "size": 2010,
            "digest": "sha256:eb9629010a6915a7026207edd91836516ecbdcd51a58e1463a99787e5f73ce06",
            "platform": {
                "architecture": "arm64",
                "os": "linux"
            }
        },
        {
            "mediaType": "application/vnd.oci.image.manifest.v1+json",
            "size": 567,
            "digest": "sha256:b85e3b09c7ee9dc06be9a7bc67e3178c62f57b53c5f808ca4429f6e0483c77ba",
            "platform": {
                "architecture": "unknown",
                "os": "unknown"
            }
        },
        {
            "mediaType": "application/vnd.oci.image.manifest.v1+json",
            "size": 567,
            "digest": "sha256:775664ffa5050d8f47d7e40f7de7a8e64d08700ff5832595499b833a5884a3e4",
            "platform": {
                "architecture": "unknown",
                "os": "unknown"
            }
        }
    ]
}

@vishnoianil vishnoianil merged commit 69538ae into instructlab:main Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants