remove combining tags steps and restructure multiple tags#346
Merged
vishnoianil merged 1 commit intoinstructlab:mainfrom Nov 17, 2024
Merged
Conversation
Signed-off-by: greg pereira <grpereir@redhat.com>
vishnoianil
approved these changes
Nov 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous workflow failed, see logs: https://github.com/instructlab/ui/actions/runs/11862220666/job/33061144701#step:13:213.
The issue here was that the extracted tag data from one of the
"${{ steps.ghcr_ui_meta.outputs.tags }}"values resolves to something likequay.io/instructlab-ui/pathservice:mainwhere as the combined tags got only the image tag, resolving topr-334. This is why it would complain because it thinks the whole image ref was pr-334 and so it couldn't build. I have refactored my approach to the tagging which I think should work, and refactored for simplicity.cc @vishnoianil @nerdalert