Conversation
There was a problem hiding this comment.
What is this binary? Is this needed?
There was a problem hiding this comment.
@vishnoianil most likely has this answer
There was a problem hiding this comment.
interesting, why does it shows as a binary, it's another container file for building image for the path service. here -> https://github.com/instructlab/ui/blob/main/Containerfile.ps
There was a problem hiding this comment.
Yeah makes sense. Just re-implement it as a containerfile @cooktheryan. Or is it that Github is recognizing it as a binary when its not?
There was a problem hiding this comment.
@Gregory-Pereira @vishnoianil i'm wondering it is the extension. Looking at the initial PR it appears this way as well
b2bec65#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L42
There was a problem hiding this comment.
@cooktheryan I think we should move these container files to "src" and "pathservice" directory so that they can live as a "Containerfile" (It will require some changes in makefile and github actions)? wdyt?
Doesn't need to be part of this PR, we can take care of it separately
There was a problem hiding this comment.
@vishnoianil ill try to keep them as part of this PR just to be less impactful with needing to land the changes immediately together. Will have something after a bit
There was a problem hiding this comment.
or we could rename it ps.Containerfile
There was a problem hiding this comment.
didn't even think about that 🤦
cooktheryan
force-pushed
the
container_images
branch
from
b9fa88e to
697187d
Compare
|
Hold until #334 |
|
@cooktheryan just say when ready for this to go in. Ty. |
Signed-off-by: Ryan Cook <rcook@redhat.com>
Signed-off-by: Ryan Cook <rcook@redhat.com>
cooktheryan
force-pushed
the
container_images
branch
from
697187d to
20105bd
Compare
|
@brents-pet-robot @nerdalert ready for review |
|
@vishnoianil this can merge. Tested on a clean AWS instance with no login |
4 participants
To support Konflux in the future the images must use RHEL based images