Upload an existing yaml file#324
Conversation
|
Awesome thanks! Taking a look. |
aevo98765
force-pushed
the
issue/#241/upload-yaml-file
branch
from
51991ec to
be6af92
Compare
|
Rebased with updated next.js (v15) |
|
Hey @nerdalert, @mingxzhao, @vishnoianil, rebase has been done and this one is ready for review when you guys get chance. |
vishnoianil
left a comment
vishnoianil
left a comment
There was a problem hiding this comment.
Overall PR looks good. Testing locally for both skill and knowledge and it works!!. Added minor comment and one suggestion on the UX.
| /> | ||
| } | ||
| > | ||
| <FormGroup fieldId="text-file-with-restrictions-example"> |
There was a problem hiding this comment.
I am wondering if this can be a simple button that says "Upload Existing Skill" that takes yaml/yml file as an input? Current form-group gives an impression that it's the part of the existing form.
|
@Misjohns This PR adds a feature where user can upload an existing skill/knowledge yaml file (in case they save the yaml to resume the work later). Current PR adds it as a form group (see below snapshot). 
I am wondering if we should use a button that says "Upload Existing Yaml" button. What would you recommend here? |
|
@aevo98765 We upgraded the main branch to pattternfly6 now, so you might have to rebase your branch over main, and give it a test run. |
|
So the proposal would be to add this to the contribution form? The user would still need to fill out the other fields in the form to submit? @aevo98765 @vishnoianil |
|
I recommend placing this feature at the very top of the page. I have included my recommendations below. Once we settle on a direction I'll get someone from content to finesse the copy.
|
Yes, yaml will fill all the fields for which data is available in yaml, rest all field will be filled by the contributor (such as email/name, brief description etc). |
I am more inclined toward second option, because it's more visible, compared to link in first option. |
mingxzhao
left a comment
mingxzhao
left a comment
There was a problem hiding this comment.
LGTM, agreed to second option, looks much cleaner and clearer
|
One minor tweak to Option 2. We should make the YAML button a secondary button instead of a primary. The primary button is at the bottom of the form to submit. |
…kills Signed-off-by: Ash Evans <ash.evans@ibm.com>
…g a function to populate the knowledge form fields Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
…and answers Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
aevo98765
force-pushed
the
issue/#241/upload-yaml-file
branch
from
b88d2ae to
97e5b8d
Compare
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
…or handling Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
|
|
|
Hey guys, sorry this has taken a while. Please see the screenshots above of the new components. This is functioning and users can now upload complete or partial yaml files for both skills and knowledge. However, the error handling needs to be implemented. I don't have the bandwidth to do this in the next week or so. Therefore I have created a new issue and sel-assigned to sort this out. |
|
@vishnoianil g2g on this one? |
vishnoianil
left a comment
vishnoianil
left a comment
There was a problem hiding this comment.
/LGTM
Awesome work as usual @aevo98765
4 participants
This feature was requested to allow users that had downloaded/curated partial yaml files to be able to upload their yaml and continue on using the UI.
Fixes #241