Align the local dev login page with the Oauth login page#313
Merged
vishnoianil merged 2 commits intoinstructlab:mainfrom Nov 13, 2024
Merged
Align the local dev login page with the Oauth login page#313vishnoianil merged 2 commits intoinstructlab:mainfrom
vishnoianil merged 2 commits intoinstructlab:mainfrom
Conversation
nerdalert
force-pushed
the
local-login-page
branch
from
b63c0a1 to
e8e7a0c
Compare
Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
- Break out the local login into a new client side file to avoid rehydration errors in nextjs v15 Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
nerdalert
force-pushed
the
local-login-page
branch
from
e8e7a0c to
1cc5022
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the local login page from the default Patternfly form to match the SaaS login when started in dev mode. I don't really like the text but we can set it to whatever in another PR:
This also breaks out locallogin in a similar pattern to github login to resolve hydration errors from nextjs v15.