Skip to content

adding gap between form elements skill and knowledge#310

Merged
nerdalert merged 2 commits intoinstructlab:mainfrom
ashapadmashetti:main
Nov 4, 2024
Merged

adding gap between form elements skill and knowledge#310
nerdalert merged 2 commits intoinstructlab:mainfrom
ashapadmashetti:main

Conversation

@ashapadmashetti
Copy link
Collaborator

adding gap between form elements skill and knowledge
improved validation and error messages

closes : #149

improved validation

Signed-off-by: Asha Padmashetti <asha.padmashetti@gmail.com>
@ashapadmashetti ashapadmashetti added the cherry-pick-release-1.0 Label to cherry-pick PR from main to release-1.0 branch. label Oct 30, 2024
Signed-off-by: Asha Padmashetti <asha.padmashetti@gmail.com>
Copy link
Member

@nerdalert nerdalert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nerdalert nerdalert merged commit 171da8e into instructlab:main Nov 4, 2024
@vishnoianil
Copy link
Member

@ashapadmashetti can you please also cherry-pick it to release-1.0 branch as well. thanks

@ashapadmashetti
Copy link
Collaborator Author

@vishnoianil Sure I will cherry-pick it to release-1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-release-1.0 Label to cherry-pick PR from main to release-1.0 branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve from elements across GUI

3 participants