Skip to content

Tech debt/#293/author information duplication#294

Merged
nerdalert merged 6 commits intoinstructlab:mainfrom
aevo98765:tech-debt/#293/author-information-duplication
Oct 28, 2024
Merged

Tech debt/#293/author information duplication#294
nerdalert merged 6 commits intoinstructlab:mainfrom
aevo98765:tech-debt/#293/author-information-duplication

Conversation

@aevo98765
Copy link
Member

@aevo98765 aevo98765 commented Oct 23, 2024

I have made a generic AuthorInformation component that is now shared between Knowledge and Skills form.

Fixes #293

Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
…uthorInformation component

Signed-off-by: Ash Evans <ash.evans@ibm.com>
…orInformation component

Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Copy link
Member

@nerdalert nerdalert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nerdalert nerdalert merged commit 5a7a109 into instructlab:main Oct 28, 2024
@vishnoianil
Copy link
Member

@aevo98765 Can you please cherry-pick this to release-1.0 branch as well.

@vishnoianil vishnoianil added the cherry-pick-release-1.0 Label to cherry-pick PR from main to release-1.0 branch. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-release-1.0 Label to cherry-pick PR from main to release-1.0 branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove duplication of the AuthorInformation component

3 participants