Update login page background responsiveness#284
Merged
nerdalert merged 2 commits intoinstructlab:mainfrom Oct 20, 2024
Merged
Conversation
Removes height-based width declaration, adjusts background resizing to keep in full view, and swaps PNG with crisper SVG. Signed-off-by: Andy Braren <abraren@redhat.com>
andybraren
force-pushed
the
login-page-resizing
branch
from
5179a34 to
045b536
Compare
Member
|
@andybraren can you please cherry-pick to release-1.0 branch as well. |
vishnoianil
added
the
cherry-pick-release-1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definitely not perfect, but fixes a few things for now:
containto always keep Lemmy in view and never stretchedmin-width: 100vh) to fix horizontal scrollbars from showingBelow I've also included what this would look like with the updated background image of #283, which removes the hard corners. Might tweak that a bit more.
cc @aevo98765
Before
Roughly approximating what's seen on a vertical monitor, a floating window, and a full 16:9 window.
After
Or with the new background image of #283: