Update login background images#283
Merged
nerdalert merged 1 commit intoinstructlab:mainfrom Oct 20, 2024
Merged
Conversation
andybraren
force-pushed
the
fix-login-background-image
branch
from
f055be9 to
cfb2a90
Compare
Contributor
Author
|
Tweaked this a bit further to remove the hard corners, which will matter for an upcoming PR to adjust the resizing behavior of the background image on the login page. |
andybraren
force-pushed
the
fix-login-background-image
branch
from
cfb2a90 to
0ec9cd9
Compare
andybraren
changed the title
Adjusts alignment, removes artifacts, and removes hard edges for responsive purposes. Signed-off-by: Andy Braren <abraren@redhat.com>
andybraren
force-pushed
the
fix-login-background-image
branch
from
0ec9cd9 to
759cebb
Compare
vishnoianil
added
the
cherry-pick-release-1.0
Member
|
@andybraren can you please cherry-pick this to release-1.0 branch as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The background image used in the login page has some slight misalignment and yellow artifacts around the edges, most noticeable in the top- and bottom-right corners. See below.
This PR replaces the PNG and SVG versions files with fixed versions.
Before
After