ci: add linter for github actions#266
Conversation
this is an action we use in other instructlab repos to lint github actions within repos to ensure new or changed actions will run without issue Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
nathan-weinberg
requested review from
a team,
Gregory-Pereira,
chungtan,
juancappi,
n1hility,
nerdalert and
renrenstart
and removed request for
a team
vishnoianil
left a comment
vishnoianil
left a comment
There was a problem hiding this comment.
Thanks for the PR @nathan-weinberg. PR looks good to me.
Given that we are running the workflows on pull_request event, do we really need to run it on push as well? assuming merge requires all the jobs to pass.
Thank you @vishnoianil! A good point - we do this in the other repos and in terms of CI costs it doesn't add any extra, so I'd prefer to keep it in if that's alright |
Sounds good. |
2 participants
this is an action we use in other instructlab repos to lint github actions within repos to ensure new or changed actions will run without issue