Dashboard Page: Update with Sorted Table, Add Empty States to Table#259
Dashboard Page: Update with Sorted Table, Add Empty States to Table#259zhuje wants to merge 2 commits intoinstructlab:mainfrom
Conversation
|
@zhuje If you are still having issue for github authentication setup, please ping me on slack, and i am happy to debug it with you. Also please fix the UI lint (run Once you login with the github, you will see that we have the empty state. Pushed through the following PR#176. Please review the existing empty state page and see if there are any gaps that needs to be address. Progress on 1) looks great to me. Thanks for the mockups. @Misjohns Please review the mockups and share your thoughts. |
|
Thank you @zhuje looking good. We probably could use PF status icons for status but we don't need anything for created and updated. |
|
@Misjohns I left the icons in there by accident, those where from the Patternfly template for responsive tables. I'll remove the icons from the I might leave out the attribute search/text filtering in this iteration of the Table. It's adding a bit of complexity that is growing the PR. We can add the attribute search/text filtering as a separate feature in the future if you still want to proceed with that. WDYT? Sorry, about the slowed progress, I have some other priorities that took my attention. I'm still continuing with the work on this PR. |
|
Agree, we can add the search at a later time. |
zhuje
force-pushed
the
issue_96_empty_state_dashboards
branch
from
e40b13b to
0daf328
Compare
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
zhuje
force-pushed
the
issue_96_empty_state_dashboards
branch
from
0daf328 to
fab9e0c
Compare
zhuje
changed the title
|
@zhuje Thank you for working on this. Let's swap to the compact labels, this will give them a bit more space. |
|
@zhuje Trying to run your PR locally, the dashboard doesn't looks like above snapshot. Browser shows following error Also we recently upgrade the main branch to patternfly6, so pleas rebase your branch over the main branch. |
|
Please locally run |
| </PageSection> | ||
| <PageSection> | ||
| <div style={{ marginBottom: '20px' }} /> | ||
| {!isFirstPullDone && ( |
There was a problem hiding this comment.
With you PR, if you click on Skill or Knowledge and again click on Dashboard, it will show the empty state page and than shows the list of contributions.
Another scenario, where you are first time logging in, it sometime takes few seconds to fetch the list of PRs, but during that time it shows the empty state, that gives a feeling to the user that they lost their contribution.
To avoid these two scenario, we check for the first pull (isFirstPullDone), if it's not done, it will show a popup that says "Retrieving all your skills and knowledge...". If there is any better alternative for this with Empty state, i would love to see that, otherwise we should show the popup while the data is loading. We should show empty state, only when there is no existing contribution from user.
3 participants
Related to issue(s)
#96
Overview:
This is a PR that addresses only the
Submissionspage.Before:
After