153: Attribute information improvements#193
Conversation
ediazgallego
requested review from
Misjohns,
aevo98765,
jjasghar and
vishnoianil
ediazgallego
force-pushed
the
153-attribute-improvements
branch
from
7439130 to
e34c3ca
Compare
Signed-off-by: ediazgallego <ediazgallego93@gmail.com>
Signed-off-by: ediazgallego <ediazgallego93@gmail.com>
|
Are we going to implement the logic here to auto-populate the other attribution fields like suggested in the issue? The re-ordering of the input fields looks good so great job with this! |
Not very familiar how big or small the changes should be for each PR, but to me the auto-populate logic seems a different concern than fixing the formatting part, so maybe creating another issue that will focus on fixing that part could be a good idea, wdyt? |
|
Happy with this. I think the smaller increments we push to main the better. Lets make sure that all the important contextual information get populated into the new issue. Put a link to the new issue in here when created. Then we will get this pushed through. |
@aevo98765 here is the new issue created as a follow-up of the remaining work to complete the full logic of auto-populate behavior 195 |
|
@ediazgallego Tracking through different issue sounds good. Thanks for creating the issue. This PR looks good to me. |
vishnoianil
left a comment
vishnoianil
left a comment
There was a problem hiding this comment.
LGTM, Thanks for the contribution! @ediazgallego
3 participants
Why
Existing implementation: The existing form places the URL after the name requiring user to manually enter all fields
UX recommendations
What:
Reference
How to test:
Screenshots
Before
After