22: Add configuration options for introducing dependabot#180
22: Add configuration options for introducing dependabot#180vishnoianil merged 4 commits intoinstructlab:mainfrom
Conversation
|
Might need one of the maintainers to help me with enabling this on the repo settings: Other questions:
|
vishnoianil
requested review from
a team,
Gregory-Pereira,
aevo98765,
chungtan,
juancappi,
renrenstart and
vishnoianil
and removed request for
a team
@adigidh This is done.
I think weekly would be a better option.
We have instructlab/ui-maintainers group that has all the maintainers in it. I think it's good to add that group as a reviewer. If that doesn't workout, please add me and @nerdalert as a reviewer.
Thanks for the PR @adigidh , Great work! Appreciate it. |
|
@adigidh Can you please signoff your commit, so that it can pass the DCO job. Thanks! |
vishnoianil
removed request for
Gregory-Pereira,
aevo98765,
chungtan,
juancappi and
renrenstart
vishnoianil
left a comment
vishnoianil
left a comment
There was a problem hiding this comment.
Overall PR looks good. Minor comments and requires DCO fixing.
.github/dependabot.yml
Outdated
| labels: | ||
| - "npm dependencies" | ||
| - "frontend" | ||
| open-pull-requests-limit: 3 |
There was a problem hiding this comment.
I think we can probably remove this limit ?
There was a problem hiding this comment.
removing the limit as suggested. We can add it back in later incase we feel like dependabot is introducing a lot of noise with PRs per week 👍
.github/dependabot.yml
Outdated
| - "go dependencies" | ||
| open-pull-requests-limit: 3 | ||
| - package-ecosystem: "docker" | ||
| directory: "/server" |
There was a problem hiding this comment.
I think we should point it to /deploy directory?
There was a problem hiding this comment.
the dockerfile is in the server directory, and we'll have to specify the root directory where dependabot should look for dockerfiles. The /deploy directory didn't have any dockerfiles.
There was a problem hiding this comment.
that makes sense. We don't use the docker file in /server currently. Mainly we use the one present in the root directory -Containerfile and Containerfile.ps, so i think we should point it to /?
There was a problem hiding this comment.
Good to know. Appreciate the details, I just made the update.
.github/dependabot.yml
Outdated
| schedule: | ||
| interval: "monthly" | ||
| labels: | ||
| - "docker dependencies" No newline at end of file |
Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
adigidh
force-pushed
the
22-dependabot
branch
from
8364a1f to
865bde0
Compare
|
Thanks for taking a look @vishnoianil. Summary of changes:
|
awesome, one minor comment and it's good to go. |
Signed-off-by: Aditya Gidh <aagidh@us.ibm.com>
|
@adigidh Thank you for your contribution! |
2 participants
fixes #22
Enabling dependabot for the repository. The configuration aims at addressing Docker images, npm packages, and go modules.
Summary of changes:
github-actions, I just used a single group, and used a wildcard pattern to achieve like an "everything group".dependency-type: "production"