Log the error, rather than rendering it#178
Merged
nerdalert merged 2 commits intoinstructlab:mainfrom Sep 18, 2024
Merged
Conversation
vishnoianil
force-pushed
the
bug-fix
branch
from
18c66d7 to
34bae80
Compare
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
vishnoianil
force-pushed
the
bug-fix
branch
from
34bae80 to
8d9d8bb
Compare
Member
Author
|
snapshot of the modal with spinner. |
Currently it shows the empty state and then once the PRs are pulled, it shows the list. This flicker of empty list always happen whenever we switch from any other menu item to Dashboar. Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
vishnoianil
force-pushed
the
bug-fix
branch
from
dce6d95 to
19e84cf
Compare
nerdalert
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show a modal with spinner while retrieving the data from github.
Currently it shows the empty state and then once the PRs are
pulled, it shows the list. This flicker of empty list always
happen whenever we switch from any other menu item to Dashboard.
Also it logs the error message rather than showing it as a div on the page.
We need a notification button to show these errors/info.